Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 28, 2025

This PR introduces new env var: CUBEJS_PRE_AGGREGATIONS_ALLOW_NON_STRICT_DATE_RANGE_MATCH which is set to true by default.
If Pre-aggregation in data model includes allowNonStrictDateRangeMatch property - it's kept as is, no changes.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review March 28, 2025 20:30
@KSDaemon KSDaemon requested review from a team as code owners March 28, 2025 20:30
@KSDaemon KSDaemon force-pushed the feat/allow_non_strict_date_range_match-on branch from cd8cdb8 to cbc8efc Compare April 7, 2025 09:30
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.90%. Comparing base (4d1b17a) to head (9fea92f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/env.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4d1b17a) and HEAD (9fea92f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4d1b17a) HEAD (9fea92f)
cubesql 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9404       +/-   ##
===========================================
- Coverage   83.91%   47.90%   -36.01%     
===========================================
  Files         229      171       -58     
  Lines       83657    21424    -62233     
  Branches        0     3713     +3713     
===========================================
- Hits        70197    10264    -59933     
+ Misses      13460    10727     -2733     
- Partials        0      433      +433     
Flag Coverage Δ
cube-backend 47.90% <66.66%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/allow_non_strict_date_range_match-on branch from cbc8efc to 9fea92f Compare April 10, 2025 18:21
@KSDaemon KSDaemon merged commit 74768e2 into master Apr 11, 2025
68 checks passed
@KSDaemon KSDaemon deleted the feat/allow_non_strict_date_range_match-on branch April 11, 2025 08:58
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…ch = true by default (cube-js#9404)

* feat(schema-compiler)!: Set preAggregation.allowNonStrictDateRangeMatch = true by default

* fix tests

* Update docs

---------

Co-authored-by: Igor Lukanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants