fix(tesseract): Fix issues with member expressions over multi stage #9416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9416 +/- ##
==========================================
- Coverage 83.72% 76.56% -7.17%
==========================================
Files 229 400 +171
Lines 82614 105052 +22438
Branches 0 3708 +3708
==========================================
+ Hits 69172 80436 +11264
- Misses 13442 24180 +10738
- Partials 0 436 +436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
reviewed
Apr 8, 2025
packages/cubejs-schema-compiler/test/integration/postgres/member-expression.test.ts
Outdated
Show resolved
Hide resolved
| pub row_limit: Option<String>, | ||
| pub offset: Option<String>, | ||
| pub ungrouped: Option<bool>, | ||
| #[serde(rename = "exportAnnotatedSql")] |
Member
There was a problem hiding this comment.
Btw, instead of tagging every property, you can tag the struct with #[serde(rename_all = "camelCase")] and it will do everything you need :) but it's just one line → code looks cleaner and more compact.
rust/cubesqlplanner/cubesqlplanner/src/planner/planners/multi_stage/member_query_planner.rs
Outdated
Show resolved
Hide resolved
.../cubesqlplanner/cubesqlplanner/src/planner/planners/multi_stage/multi_stage_query_planner.rs
Outdated
Show resolved
Hide resolved
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List