Skip to content

fix(tesseract): Fix for multi fact queries #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix(tesseract): Fix for multi fact queries #9421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13bd2f0
fix(tesseract): Fix for multi fact queries
waralexrom Apr 3, 2025
842f859
fix
waralexrom Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,17 @@ export class BaseQuery {
}

prebuildJoin() {
/* if (!this.useNativeSqlPlanner) { We still need this join for the follback to preaggregation to work properly. This condition should be returned after the tesseract starts working with pre-aggregations
if (this.useNativeSqlPlanner) {
// Tesseract doesn't require join to be prebuilt and there's a case where single join can't be built for multi-fact query
// But we need this join for a fallback when using pre-aggregations. So we’ll try to obtain the join but ignore any errors (which may occur if the query is a multi-fact one).
try {
this.join = this.joinGraph.buildJoin(this.allJoinHints);
} catch (e) {
// Ignore
}
} else {
this.join = this.joinGraph.buildJoin(this.allJoinHints);
} */

this.join = this.joinGraph.buildJoin(this.allJoinHints);
}
}

cacheValue(key, fn, { contextPropNames, inputProps, cache } = {}) {
Expand Down Expand Up @@ -391,7 +396,7 @@ export class BaseQuery {
initUngrouped() {
this.ungrouped = this.options.ungrouped;
if (this.ungrouped) {
if (!this.options.allowUngroupedWithoutPrimaryKey) {
if (!this.options.allowUngroupedWithoutPrimaryKey && this.join) {
const cubes = R.uniq([this.join.root].concat(this.join.joins.map(j => j.originalTo)));
const primaryKeyNames = cubes.flatMap(c => this.primaryKeyNames(c));
const missingPrimaryKeys = primaryKeyNames.filter(key => !this.dimensions.find(d => d.dimension === key));
Expand Down
Loading