Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This is to avoid issues like "GHA updated CMake, and now librdkafka won't build"

@mcheshkov mcheshkov force-pushed the cubestore-ci-container branch from 745b8c9 to 83dbc9f Compare April 4, 2025 10:50
@mcheshkov mcheshkov marked this pull request as ready for review April 4, 2025 12:10
@mcheshkov mcheshkov requested a review from a team as a code owner April 4, 2025 12:10
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@mcheshkov mcheshkov merged commit c1e5128 into master Apr 4, 2025
53 checks passed
@mcheshkov mcheshkov deleted the cubestore-ci-container branch April 4, 2025 12:51
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* ci(cubestore): Run CI workflow in container

* ci(cubestore): Remove jobs limit for build and test

* ci(cubestore): Setup TMPDIR explicitly

* test(cubestore): Bump test timeout to account for data.wprdc.org slowness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants