Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 4, 2025

In this PR OrchestratorStorage is switched to use LRUCache instead of simple js Map.

This PR depends on 9424 because it uses lru-cache v11.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review April 4, 2025 10:39
@KSDaemon KSDaemon requested a review from a team as a code owner April 4, 2025 10:39
@KSDaemon KSDaemon force-pushed the feat/Orchestrator-Storage-lru branch from 4c34dd2 to dcd7f4f Compare April 7, 2025 09:24
@KSDaemon KSDaemon requested a review from ovr April 7, 2025 09:41
@KSDaemon KSDaemon force-pushed the feat/Orchestrator-Storage-lru branch 2 times, most recently from e5d9538 to 1a22655 Compare April 8, 2025 12:39
@KSDaemon KSDaemon force-pushed the feat/script-cache branch from ae25475 to efd95f9 Compare April 8, 2025 12:51
@KSDaemon KSDaemon force-pushed the feat/Orchestrator-Storage-lru branch 2 times, most recently from f510618 to 4a74774 Compare April 8, 2025 12:53
Base automatically changed from feat/script-cache to master April 8, 2025 14:15
@KSDaemon KSDaemon requested review from a team as code owners April 8, 2025 14:15
KSDaemon added 2 commits April 8, 2025 17:16
# Conflicts:
#	packages/cubejs-server-core/src/core/CompilerApi.js
@KSDaemon KSDaemon force-pushed the feat/Orchestrator-Storage-lru branch from 4a74774 to 259b85b Compare April 8, 2025 14:16
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.92%. Comparing base (e923a0f) to head (259b85b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-server-core/src/core/OrchestratorStorage.ts 66.66% 2 Missing ⚠️
...ackages/cubejs-server-core/src/core/CompilerApi.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9425   +/-   ##
=======================================
  Coverage   47.91%   47.92%           
=======================================
  Files         171      171           
  Lines       21335    21327    -8     
  Branches     3691     3690    -1     
=======================================
- Hits        10223    10221    -2     
+ Misses      10677    10671    -6     
  Partials      435      435           
Flag Coverage Δ
cube-backend 47.92% <70.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit ede37f8 into master Apr 8, 2025
68 checks passed
@ovr ovr deleted the feat/Orchestrator-Storage-lru branch April 8, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants