Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 4, 2025

Update the transpilation flow to use Native transpilation with file batching instead of processing files one by one, improving performance.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (3df5613) to head (e2d5206).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...schema-compiler/src/compiler/DataSchemaCompiler.js 26.66% 33 Missing ⚠️
packages/cubejs-backend-native/js/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9427       +/-   ##
===========================================
+ Coverage   47.91%   76.56%   +28.64%     
===========================================
  Files         171      400      +229     
  Lines       21387   105078    +83691     
  Branches     3707     3712        +5     
===========================================
+ Hits        10248    80452    +70204     
- Misses      10702    24189    +13487     
  Partials      437      437               
Flag Coverage Δ
cube-backend 47.87% <27.65%> (-0.05%) ⬇️
cubesql 83.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 4, 2025 11:18
@KSDaemon KSDaemon requested review from a team as code owners April 4, 2025 11:18
@KSDaemon KSDaemon force-pushed the feat/bulk-transpile-native branch from fa25280 to f1be2d7 Compare April 7, 2025 09:30
@KSDaemon KSDaemon force-pushed the feat/bulk-transpile-native branch from f1be2d7 to e2d5206 Compare April 10, 2025 14:53
@KSDaemon KSDaemon merged commit c274b2a into master Apr 10, 2025
87 checks passed
@KSDaemon KSDaemon deleted the feat/bulk-transpile-native branch April 10, 2025 16:52
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
… in native (cube-js#9427)

* add stage for transpile native

* move file content into transform request struct

* change native transpile() interface to expect arrays

* implement bulk transpileJsFiles in native

* small update in getThreadsCount

* quickfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants