refactor(schema-compiler): More types for CubeEvaluator, CubeSymbols and DynamicReference #9429
Conversation
| ) | ||
| )) | ||
| .map(cube => { | ||
| .flatMap(cube => { |
| const cubes = type === 'dimensions' ? cube.cubes.map((it) => { | ||
| const fullPath = this.evaluateReferences(null, it.joinPath, { collectJoinHints: true }); | ||
| // TODO recheck `it.joinPath` typing | ||
| const fullPath = this.evaluateReferences(null, it.joinPath as () => { toString(): string }, { collectJoinHints: true }); |
There was a problem hiding this comment.
Maybe it would be better to define an interface for () => { toString(): string } instead of copy-pasting many times it as () => { toString(): string } ? At least for now. wdyt?
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 LGTM After the copy-paste removal :)
mcheshkov
force-pushed
the
evaluator-symbols-more-types
branch
from
b9b829d to
d6d638c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9429 +/- ##
===========================================
- Coverage 76.40% 47.86% -28.55%
===========================================
Files 400 171 -229
Lines 104055 21312 -82743
Branches 3685 3687 +2
===========================================
- Hits 79508 10201 -69307
+ Misses 24112 10676 -13436
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…and DynamicReference (cube-js#9429) * refactor(schema-compiler): More types in CubeEvaluator * refactor(schema-compiler): Port DynamicReference to TypeScript * refactor(schema-compiler): More types in CubeSymbols * refactor(schema-compiler): Extract ToString type
Check List