Skip to content

Conversation

@KSDaemon
Copy link
Member

Switch to the brand new OSS JDBC Driver proposed by Databricks.
Read more here.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon force-pushed the feat/databrick-oss-driver branch from 2625fd9 to 6753e19 Compare April 10, 2025 17:40
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.86%. Comparing base (a247bf9) to head (33248d7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/http-utils.ts 12.50% 7 Missing ⚠️
packages/cubejs-backend-shared/src/env.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9450      +/-   ##
==========================================
- Coverage   47.88%   47.86%   -0.03%     
==========================================
  Files         171      171              
  Lines       21412    21420       +8     
  Branches     3707     3710       +3     
==========================================
- Hits        10254    10252       -2     
- Misses      10726    10736      +10     
  Partials      432      432              
Flag Coverage Δ
cube-backend 47.86% <8.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 10, 2025 18:18
@KSDaemon KSDaemon requested review from a team as code owners April 10, 2025 18:18
@KSDaemon KSDaemon force-pushed the feat/databrick-oss-driver branch from a71c852 to 670cf90 Compare April 11, 2025 10:48
@KSDaemon KSDaemon force-pushed the feat/databrick-oss-driver branch from 670cf90 to 33248d7 Compare April 11, 2025 11:17
@KSDaemon KSDaemon merged commit 819edde into master Apr 11, 2025
59 checks passed
@KSDaemon KSDaemon deleted the feat/databrick-oss-driver branch April 11, 2025 13:10
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…C driver (cube-js#9450)

* feat(databricks-jdbc-driver): Switch to the latest OSS Databricks JDBC driver

* remove UID and PWD from URL

* fix some notes after review

* update driver version

* add comment

* Revert "update driver version"

This reverts commit 5e9f7dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants