fix(cubesql): Fix SortPushDown pushing sort through joins #9464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9464 +/- ##
===========================================
+ Coverage 58.98% 80.54% +21.56%
===========================================
Files 153 382 +229
Lines 12973 96521 +83548
Branches 2192 2192
===========================================
+ Hits 7652 77743 +70091
- Misses 5010 18467 +13457
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
approved these changes
Apr 21, 2025
LogicalPlan::Join and CrossJoin do not preserve the ordering semantically When planned as HashJoin it will output batches in same order as they are coming from right stream But both Join and CrossJoin will have same partitioning as right input (even when repartition_joins disabled), and these partitions can be collected in arbitrary order by CoalescePartitions See https://github.com/apache/datafusion/blob/7.0.0/datafusion/src/physical_plan/hash_join.rs#L282-L284 See https://github.com/apache/datafusion/blob/7.0.0/datafusion/src/physical_plan/cross_join.rs#L141-L143 Also, Substrait says that for both Join and Cross Product > Orderedness is empty post operation See https://substrait.io/relations/logical_relations/#join-operation
mcheshkov
force-pushed
the
sort-push-down-join
branch
from
b9303ee to
fc2339b
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
LogicalPlan::Join and CrossJoin do not preserve the ordering semantically When planned as HashJoin it will output batches in same order as they are coming from right stream But both Join and CrossJoin will have same partitioning as right input (even when repartition_joins disabled), and these partitions can be collected in arbitrary order by CoalescePartitions See https://github.com/apache/datafusion/blob/7.0.0/datafusion/src/physical_plan/hash_join.rs#L282-L284 See https://github.com/apache/datafusion/blob/7.0.0/datafusion/src/physical_plan/cross_join.rs#L141-L143 Side note: Substrait says that for both Join and Cross Product > Orderedness is empty post operation See https://substrait.io/relations/logical_relations/#join-operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
LogicalPlan::JoinandCrossJoindo not preserve the ordering semanticallyWhen planned as
HashJoinit will output batches in same order as they are coming from right streamBut both
JoinandCrossJoinwill have same partitioning as right input (even whenrepartition_joinsdisabled), and these partitions can be collected in arbitrary order byCoalescePartitionsSide note: Substrait says that for both Join and Cross Product
See https://substrait.io/relations/logical_relations/#join-operation