Skip to content

Conversation

@igorlukanin
Copy link
Member

@igorlukanin igorlukanin commented Apr 15, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@igorlukanin igorlukanin requested a review from a team as a code owner April 15, 2025 12:46
@igorlukanin igorlukanin changed the title Add docs Custom granularities support for Amazon Athena and Amazon Redhsift Apr 15, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.45%. Comparing base (854e330) to head (e78a45f).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...ubejs-schema-compiler/src/adapter/PrestodbQuery.ts 11.11% 8 Missing ⚠️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (854e330) and HEAD (e78a45f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (854e330) HEAD (e78a45f)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9472       +/-   ##
===========================================
- Coverage   83.89%   58.45%   -25.45%     
===========================================
  Files         229      167       -62     
  Lines       83544    14937    -68607     
  Branches        0     2955     +2955     
===========================================
- Hits        70087     8731    -61356     
+ Misses      13457     5861     -7596     
- Partials        0      345      +345     
Flag Coverage Δ
cube-backend 58.45% <30.76%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@KSDaemon KSDaemon requested a review from a team as a code owner April 17, 2025 11:03
@KSDaemon KSDaemon changed the title Custom granularities support for Amazon Athena and Amazon Redhsift Custom granularities support for Amazon Athena Apr 17, 2025
@KSDaemon KSDaemon changed the title Custom granularities support for Amazon Athena feat(schema-compiler): Custom granularities support for Amazon Athena/Presto dialect Apr 17, 2025
@KSDaemon KSDaemon force-pushed the feat/custom-granularities-athena-and-redshift branch from 762d304 to e78a45f Compare April 17, 2025 17:09
@KSDaemon KSDaemon merged commit 4c1520e into master Apr 23, 2025
68 checks passed
@KSDaemon KSDaemon deleted the feat/custom-granularities-athena-and-redshift branch April 23, 2025 08:10
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…/Presto dialect (cube-js#9472)

* Add docs

* code hygiene

* feat(schema-compiler): Custom granularities support for AWS Athena/Presto dialect

---------

Co-authored-by: Konstantin Burkalev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants