-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Make RefreshKeySql timezone-aware #9479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9479 +/- ##
===========================================
- Coverage 83.88% 58.47% -25.41%
===========================================
Files 229 167 -62
Lines 83544 14928 -68616
Branches 0 2955 +2955
===========================================
- Hits 70079 8729 -61350
+ Misses 13465 5853 -7612
- Partials 0 346 +346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* code polish * a bit of types * code polish * grammar fix * code polish * fix(schema-compiler): Make RefreshKeySql timezone-aware * update moment-timezone * fix docs * fix tests
This PR makes RefreshKey SQL generation to use the query timezone. This is important for the case when there are a few scheduled refresh timezones (or even one but different from
UTC) and there is a pre-aggregation withdaypartition granularity. So you want them to be updated at midnight in the provided timezone rather than atUTC.This fixes it.
The change is also made in cron-based refresh keys, making them timezone-aware. If the pre-aggregation
refresh_keydoes not define atimezone, then thetimezoneof the query will be used.Check List