feat(backend-native): Allow importing modules from python files within cube.py and globals.py
#9490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9490 +/- ##
==========================================
- Coverage 80.28% 80.27% -0.01%
==========================================
Files 395 395
Lines 97355 97355
Branches 2278 2278
==========================================
- Hits 78158 78150 -8
- Misses 18889 18897 +8
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
reviewed
Apr 23, 2025
KSDaemon
force-pushed
the
feat/py-imports
branch
2 times, most recently
from
12c6da6 to
dece67e
Compare
igorlukanin
changed the title
cube.py and globals.py
KSDaemon
force-pushed
the
feat/py-imports
branch
from
dece67e to
23a6975
Compare
KSDaemon
force-pushed
the
feat/py-imports
branch
from
60f0048 to
e4d6751
Compare
ovr
reviewed
Apr 29, 2025
KSDaemon
force-pushed
the
feat/py-imports
branch
from
e4d6751 to
3c79f20
Compare
ovr
approved these changes
Apr 30, 2025
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…n `cube.py` and `globals.py` (cube-js#9490) * feat(backend-native): Allow importing modules from python files within cube.py * update tests * Allow importing modules from python files within globals.py * tests * another test * Add docs * more tests * extract sys path to fn --------- Co-authored-by: Igor Lukanin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows to import python modules from files relative to
cube.py. See more info and issue description in #8443.Closes #8443
Check List