feat(tesseract): Logical plan #9497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9497 +/- ##
===========================================
+ Coverage 58.47% 80.23% +21.76%
===========================================
Files 169 399 +230
Lines 13990 97815 +83825
Branches 2275 2275
===========================================
+ Hits 8180 78485 +70305
- Misses 5495 19015 +13520
Partials 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
approved these changes
Apr 24, 2025
Member
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 🥇 This is great!
Left some typos...
| } | ||
|
|
||
| #[derive(Clone)] | ||
| pub enum LogicalJoinItem { |
Member
There was a problem hiding this comment.
Are any new variants expected or planned here?
Member
Author
There was a problem hiding this comment.
Yep, PreAggregationSource for example.
Member
Author
There was a problem hiding this comment.
Yep, pre aggregation for example
| } | ||
| }; | ||
|
|
||
| let time_seira = TimeSeries::new( |
Member
There was a problem hiding this comment.
Suggested change
| let time_seira = TimeSeries::new( | |
| let time_series = TimeSeries::new( |
| let mut render_references = HashMap::new(); | ||
| let mut select_builder = SelectBuilder::new(from.clone()); | ||
|
|
||
| //We insert render reference for main time dimension (with the some granularity as in time series to avoid unnessesary date_tranc) |
Member
There was a problem hiding this comment.
Suggested change
| //We insert render reference for main time dimension (with the some granularity as in time series to avoid unnessesary date_tranc) | |
| //We insert rendered reference for the main time dimension (with the same granularity as in time series to avoid unnecessary date_tranc) |
| QualifiedColumnName::new(Some(root_alias.clone()), format!("date_from")), | ||
| ); | ||
|
|
||
| //We also insert render reference for the base dimension of time dimension (i.e. without `_granularity` prefix to let other time dimensions make date_tranc) |
Member
There was a problem hiding this comment.
Suggested change
| //We also insert render reference for the base dimension of time dimension (i.e. without `_granularity` prefix to let other time dimensions make date_tranc) | |
| //We also insert rendered reference for the base dimension of the time dimension (i.e. without `_granularity` prefix to let other time dimensions make date_tranc) |
waralexrom
force-pushed
the
tesseract-logical-plan
branch
from
2d7ac7e to
37e2479
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List