Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 1, 2025

Finally, move PreAggregations from js to ts with most of the types described! 🎉

Also switching to TS uncovered some incorrectness that is now fixed!

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (ef3a04b) to head (93cf873).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ejs-schema-compiler/src/adapter/PreAggregations.ts 92.85% 3 Missing and 2 partials ⚠️
...es/cubejs-schema-compiler/src/adapter/HiveQuery.ts 0.00% 3 Missing ⚠️
...s/cubejs-schema-compiler/src/adapter/BaseFilter.ts 0.00% 0 Missing and 1 partial ⚠️
...bejs-schema-compiler/src/adapter/CubeStoreQuery.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9538      +/-   ##
==========================================
- Coverage   61.75%   61.64%   -0.11%     
==========================================
  Files         174      174              
  Lines       14434    14474      +40     
  Branches     2464     2576     +112     
==========================================
+ Hits         8913     8923      +10     
- Misses       5155     5169      +14     
- Partials      366      382      +16     
Flag Coverage Δ
cube-backend 61.64% <87.50%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review May 2, 2025 08:02
@KSDaemon KSDaemon requested review from a team as code owners May 2, 2025 08:02
@KSDaemon KSDaemon force-pushed the chore/preaggs-2-ts branch from 18237b0 to c54aa36 Compare May 7, 2025 16:04
Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Awesome! Great to see that it finally happens and TS is here for pre-aggs!

Copy link
Contributor

@mcheshkov mcheshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can land this for integration purposes, and improve on it later.

@KSDaemon KSDaemon force-pushed the chore/preaggs-2-ts branch from e7f8c9f to 93cf873 Compare May 8, 2025 16:51
@KSDaemon KSDaemon merged commit 954bda4 into master May 8, 2025
59 checks passed
@KSDaemon KSDaemon deleted the chore/preaggs-2-ts branch May 8, 2025 17:15
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…e-js#9538)

* fix typo

* add types

* remove unused

* chore(schema-compiler): move preAggregations class to typescript

* fix after conflict resolution

* one more fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants