-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(schema-compiler): move preAggregations class to typescript #9538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9538 +/- ##
==========================================
- Coverage 61.75% 61.64% -0.11%
==========================================
Files 174 174
Lines 14434 14474 +40
Branches 2464 2576 +112
==========================================
+ Hits 8913 8923 +10
- Misses 5155 5169 +14
- Partials 366 382 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
18237b0 to
c54aa36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Awesome! Great to see that it finally happens and TS is here for pre-aggs!
mcheshkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can land this for integration purposes, and improve on it later.
e7f8c9f to
93cf873
Compare
…e-js#9538) * fix typo * add types * remove unused * chore(schema-compiler): move preAggregations class to typescript * fix after conflict resolution * one more fix
Finally, move PreAggregations from js to ts with most of the types described! 🎉
Also switching to TS uncovered some incorrectness that is now fixed!