Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 13, 2025

It finally happens! Now the implementation is in sync with the spec and with types (as much as I could take)

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon force-pushed the chore/client-2-ts branch 3 times, most recently from ba02495 to a1440dc Compare May 14, 2025 09:05
@KSDaemon KSDaemon force-pushed the chore/client-2-ts branch from 99c927f to 142bec6 Compare May 15, 2025 15:19
@KSDaemon KSDaemon requested a review from vasilev-alex May 15, 2025 15:28
@KSDaemon KSDaemon force-pushed the chore/client-2-ts branch 2 times, most recently from b22131b to 58708d8 Compare May 15, 2025 17:21
@vasilev-alex vasilev-alex marked this pull request as ready for review May 16, 2025 05:15
@vasilev-alex vasilev-alex requested review from a team as code owners May 16, 2025 05:15
@KSDaemon KSDaemon force-pushed the chore/client-2-ts branch from c1a38f7 to fac9b3b Compare May 16, 2025 11:02
@KSDaemon KSDaemon merged commit e260d81 into master May 16, 2025
58 checks passed
@KSDaemon KSDaemon deleted the chore/client-2-ts branch May 16, 2025 15:43
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
* rename to ts

* Move to TS whole codebase

* Move to TS tests

* side fix :)

* fix tools settings

* temp comment out rollup for client-core

* update ts config and remove babel

* a few more type fixes

* versions sync

* return back rollup

* another try to fix rollup

* build fixes

* fix quotes

* fix ts config

* return back lint plugin

* delete removed rule

* fix lint errors

* fix lint error in BaseDriver

* fix linting in api-gateway

* fix linting in BaseQueueDriver

* fix linting in QueryTestAbstract

* more fixes

* more type fixes

* Fix more types

* fix load()

* fix vue clients

* fix getNormalizedPivotConfig()

* trying to fix dev docker img

* exclude index.umd.js from coverage

* trying to fix dev docker img

* revert all docker changes in docker file

* fix client builds

* entry point fixes

* fix quotes

* module fix

* updated uuid

* trying to fix jest tests + client core build

* remove module

* unit tests

* fix coverage

* fix entry point

* ws fix

* resolve fix

* cleanup

* fix yarn.lock

* some configs polishment

* fix after rebasing

* improve ts config for jest

* more tests for resultset

* fix test for cubeApi

* few more tests

---------

Co-authored-by: Alex Vasilev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants