Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested review from a team as code owners May 17, 2025 11:33
@codecov
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (60ad2f0) to head (733136d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9582   +/-   ##
=======================================
  Coverage   84.09%   84.10%           
=======================================
  Files         230      230           
  Lines       84409    84409           
=======================================
+ Hits        70987    70995    +8     
+ Misses      13422    13414    -8     
Flag Coverage Δ
cubesql 84.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from tesseract-bigquery to master May 18, 2025 10:23
@waralexrom waralexrom force-pushed the tesseract-improvements branch from 5668f0f to ed9dfb4 Compare May 18, 2025 17:02
@waralexrom waralexrom force-pushed the tesseract-improvements branch from 066af41 to 3f528e1 Compare May 19, 2025 14:15
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@waralexrom waralexrom changed the title Tesseract improvements chore(tesseract): Tesseract improvements May 19, 2025
@waralexrom waralexrom merged commit 22c3e97 into master May 19, 2025
74 checks passed
@waralexrom waralexrom deleted the tesseract-improvements branch May 19, 2025 16:08
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants