-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(tesseract): Fix rolling window external pre-aggregation #9625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tesseract): Fix rolling window external pre-aggregation #9625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9625 +/- ##
===========================================
+ Coverage 0 84.17% +84.17%
===========================================
Files 0 230 +230
Lines 0 85112 +85112
===========================================
+ Hits 0 71647 +71647
- Misses 0 13465 +13465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| driverTools(external) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe name it smth like queryForDriverTools or driverToolsQuery...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Tesseract’s perspective, this is indeed driverTools. In the future, I plan to extract it from BaseQuery into a separate class. In other words, Tesseract receives this through an interface that only exposes the parts of BaseQuery responsible for driver-specific SQL generation.
f5c30a8 to
ae1011e
Compare
Check List