Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested a review from a team as a code owner May 27, 2025 17:37
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (81a1ae9) to head (7ebe344).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9625       +/-   ##
===========================================
+ Coverage        0   84.17%   +84.17%     
===========================================
  Files           0      230      +230     
  Lines           0    85112    +85112     
===========================================
+ Hits            0    71647    +71647     
- Misses          0    13465    +13465     
Flag Coverage Δ
cubesql 84.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

);
}

driverTools(external) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name it smth like queryForDriverTools or driverToolsQuery...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Tesseract’s perspective, this is indeed driverTools. In the future, I plan to extract it from BaseQuery into a separate class. In other words, Tesseract receives this through an interface that only exposes the parts of BaseQuery responsible for driver-specific SQL generation.

@waralexrom waralexrom force-pushed the tesseract-rolling-window-pre-aggregation-fix branch from f5c30a8 to ae1011e Compare June 11, 2025 13:55
@waralexrom waralexrom merged commit aae3b05 into master Jun 11, 2025
77 checks passed
@waralexrom waralexrom deleted the tesseract-rolling-window-pre-aggregation-fix branch June 11, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants