Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This PR adds support for DATE_TRUNC(…) = literal filter pushing down to CubeScan. Related test is included.

@MazterQyou MazterQyou requested a review from a team as a code owner May 28, 2025 12:05
@MazterQyou MazterQyou force-pushed the cubesql/date-trunc-neq-literal branch from eaf8531 to 9c80586 Compare May 28, 2025 12:07
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (d3af150) to head (9c80586).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9627      +/-   ##
==========================================
+ Coverage   84.12%   84.14%   +0.02%     
==========================================
  Files         230      230              
  Lines       84547    84622      +75     
==========================================
+ Hits        71122    71205      +83     
+ Misses      13425    13417       -8     
Flag Coverage Δ
cubesql 84.14% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 2b36aae into master May 28, 2025
77 checks passed
@MazterQyou MazterQyou deleted the cubesql/date-trunc-neq-literal branch May 28, 2025 12:39
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants