Skip to content

fix(cubesql): Propagate errors from SqlAuthService to the user #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix(cubesql): Propagate errors from SqlAuthService to the user #9665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions packages/cubejs-api-gateway/src/sql-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,25 @@ export class SQLServer {
};
},
checkSqlAuth: async ({ request, user, password }) => {
const { password: returnedPassword, superuser, securityContext, skipPasswordCheck } = await checkSqlAuth(request, user, password);

return {
password: returnedPassword,
superuser: superuser || false,
securityContext,
skipPasswordCheck,
};
try {
const { password: returnedPassword, superuser, securityContext, skipPasswordCheck } = await checkSqlAuth(request, user, password);

return {
password: returnedPassword,
superuser: superuser || false,
securityContext,
skipPasswordCheck,
};
} catch (e) {
this.apiGateway.log({
Copy link
Member

@ovr ovr Jun 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just another problem related to how users write check_sql_auth.

Default example from the documentation:
https://cube.dev/docs/product/configuration/reference/config#check_sql_auth

It will throw an exception for incorrect username/password, but the biggest problem is that we will start to spam it in our logs.

Copy link
Member Author

@KSDaemon KSDaemon Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a problem. In a common standard flow, there will be no exceptions thrown as every real good user would be authorized and logged in. While any auth denial is an outstanding event and might be a reason to look into it.

Copy link
Member

@ovr ovr Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cC @igorlukanin

type: 'Auth Error',
protocol: (request as any).protocol,
method: (request as any).method,
apiType: 'sql',
error: (e as Error).stack || (e as Error).toString(),
});
throw e;
}
},
meta: async ({ request, session, onlyCompilerId }) => {
const context = await this.apiGateway.contextByReq(<any> request, session.securityContext, request.id);
Expand Down
Loading