chore: Use typings directly from generic-pool, not from DefinitelyTyped #9712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
force-pushed
the
refactor/use-generic-pool-types
branch
from
85192ae to
f6e744d
Compare
ovr
force-pushed
the
refactor/use-generic-pool-types
branch
from
f6e744d to
3835e02
Compare
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…ed (cube-js#9712) The generic-pool package provides typings itself. Mixing types from the package and definitely typed is a bad idea :)
igorlukanin
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ed (#9712) The generic-pool package provides typings itself. Mixing types from the package and definitely typed is a bad idea :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generic-poolpackage provides typings itself. Mixing types from the package and definitely typed is a bad idea :)