Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 26, 2025

This PR removes deprecated proxy settings obtained from npm settings. So only common HTTP_PROXY and/or HTTPS_PROXY env vars are used.

This probably fixes #9723

@KSDaemon KSDaemon marked this pull request as ready for review June 26, 2025 11:39
@KSDaemon KSDaemon requested a review from a team as a code owner June 26, 2025 11:39
@KSDaemon KSDaemon force-pushed the chore/remove-npm-proxy branch 2 times, most recently from 9e77b9b to cba004d Compare October 7, 2025 14:45
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.15%. Comparing base (cb6dc3e) to head (b241f94).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/proxy.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cb6dc3e) and HEAD (b241f94). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cb6dc3e) HEAD (b241f94)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9715       +/-   ##
===========================================
- Coverage   83.34%   49.15%   -34.20%     
===========================================
  Files         244      196       -48     
  Lines       74112    15947    -58165     
  Branches        0     3131     +3131     
===========================================
- Hits        61767     7838    -53929     
+ Misses      12345     7716     -4629     
- Partials        0      393      +393     
Flag Coverage Δ
cube-backend 49.15% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	packages/cubejs-backend-shared/package.json
@KSDaemon KSDaemon force-pushed the chore/remove-npm-proxy branch from cba004d to b241f94 Compare October 29, 2025 12:01
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 29, 2025
@KSDaemon KSDaemon merged commit f486bde into master Oct 29, 2025
83 checks passed
@KSDaemon KSDaemon deleted the chore/remove-npm-proxy branch October 29, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm: command not found in production image

2 participants