fix(native): Handle null correctly as JsNull, not as JsString #9717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9717 +/- ##
==========================================
+ Coverage 84.20% 84.32% +0.11%
==========================================
Files 230 234 +4
Lines 85315 86954 +1639
==========================================
+ Hits 71842 73321 +1479
- Misses 13473 13633 +160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KSDaemon
approved these changes
Jun 26, 2025
Member
KSDaemon
left a comment
KSDaemon
left a comment
There was a problem hiding this comment.
👍🏻 LGTM just fix cargo fmt...
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…s#9717) Fixing an unexpected issue with treating null as a null string. I figured out this issue while benchmarking the cache store queue. Previously, it could lead to an issue in the production environment while someone moves between cube store versions or has an error while updating the queue_item's extra field.
igorlukanin
pushed a commit
that referenced
this pull request
Oct 29, 2025
Fixing an unexpected issue with treating null as a null string. I figured out this issue while benchmarking the cache store queue. Previously, it could lead to an issue in the production environment while someone moves between cube store versions or has an error while updating the queue_item's extra field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.