-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(cubesql): Fix incorrect datetime parsing in filters rewrite rules #9732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5a97cf to
b75ec12
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9732 +/- ##
==========================================
+ Coverage 84.20% 84.23% +0.02%
==========================================
Files 230 231 +1
Lines 85321 85341 +20
==========================================
+ Hits 71847 71886 +39
+ Misses 13474 13455 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MazterQyou
reviewed
Jun 30, 2025
MazterQyou
approved these changes
Jun 30, 2025
MazterQyou
approved these changes
Jun 30, 2025
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…cube-js#9732) * fix(cubesql): Fix incorrect datetime parsing in filters rewrite rules * remove copy/paste * add test * fix suggestions * fix map err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes [sometimes] incorrectly parsed date range boudaries literals (not adding/subtracting milisecond).
This fixes #9628
Check List