Skip to content

feat(prestodb-driver): Support s3 export bucket #9736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025
Merged

feat(prestodb-driver): Support s3 export bucket #9736

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc914cc
dev
RusovDmitriy Jul 1, 2025
acfc4a9
dev
RusovDmitriy Jul 1, 2025
0422492
dev
RusovDmitriy Jul 1, 2025
0a83426
fix
RusovDmitriy Jul 1, 2025
48d112b
dev
RusovDmitriy Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/cubejs-prestodb-driver/src/PrestoDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const presto = require('presto-client');

export type PrestoDriverExportBucket = {
exportBucket?: string,
bucketType?: 'gcs',
bucketType?: 'gcs' | 's3',
credentials?: any,
exportBucketCsvEscapeSymbol?: string,
};
Expand All @@ -50,7 +50,7 @@ export type PrestoDriverConfiguration = PrestoDriverExportBucket & {
queryTimeout?: number;
};

const SUPPORTED_BUCKET_TYPES = ['gcs'];
const SUPPORTED_BUCKET_TYPES = ['gcs', 's3'];
/**
* Presto driver class.
*/
Expand Down Expand Up @@ -103,7 +103,7 @@ export class PrestoDriver extends BaseDriver implements DriverInterface {
...(authToken ? { custom_auth: `Bearer ${authToken}` } : {}),
...(dbPassword ? { basic_auth: { user: dbUser, password: dbPassword } } : {}),
ssl: this.getSslOptions(dataSource),
bucketType: getEnv('dbExportBucketType', { supported: ['gcs'], dataSource }),
bucketType: getEnv('dbExportBucketType', { supported: SUPPORTED_BUCKET_TYPES, dataSource }),
exportBucket: getEnv('dbExportBucket', { dataSource }),
credentials: getEnv('dbExportGCSCredentials', { dataSource }),
...config
Expand Down Expand Up @@ -351,6 +351,8 @@ export class PrestoDriver extends BaseDriver implements DriverInterface {
switch (bucketType) {
case 'gcs':
return this.extractFilesFromGCS({ credentials }, exportBucket, `${schema}/${tableName}`);
case 's3':
return this.extractUnloadedFilesFromS3({ credentials }, exportBucket, `${schema}/${tableName}`);
default:
throw new Error(`Unsupported export bucket type: ${bucketType}`);
}
Expand Down
Loading