Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cubejs-ksql-driver/src/KsqlQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ export class KsqlQuery extends BaseQuery {
return dimensionColumns.length ? ` GROUP BY ${dimensionColumns.join(', ')}` : '';
}

public partitionInvalidateKeyQueries(_cube: string, _preAggregation: any) {
return [];
}

public preAggregationStartEndQueries(cube: string, preAggregation: any) {
if (preAggregation.partitionGranularity) {
if (!preAggregation.refreshRangeStart) {
Expand Down
4 changes: 4 additions & 0 deletions packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -4456,6 +4456,10 @@ export class BaseQuery {
return `SELECT ${sql} as refresh_key`;
}

partitionInvalidateKeyQueries(_cube, _preAggregation) {
// this is not used across all dialects, atm only in KsqlQuery.
}

preAggregationInvalidateKeyQueries(cube, preAggregation, preAggregationName) {
return this.cacheValue(
['preAggregationInvalidateKeyQueries', cube, JSON.stringify(preAggregation)],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ export class PreAggregations {
const tableName = this.preAggregationTableName(cube, preAggregationName, preAggregation);
const invalidateKeyQueries = this.query.preAggregationInvalidateKeyQueries(cube, preAggregation, preAggregationName);
const queryForSqlEvaluation = this.query.preAggregationQueryForSqlEvaluation(cube, preAggregation);
// Atm this is only defined in KsqlQuery but without it partitions are recreated on every refresh
const partitionInvalidateKeyQueries = queryForSqlEvaluation.partitionInvalidateKeyQueries?.(cube, preAggregation);

const allBackAliasMembers = this.query.allBackAliasMembers();

Expand Down Expand Up @@ -298,6 +300,7 @@ export class PreAggregations {
timestampPrecision: queryForSqlEvaluation.timestampPrecision(),
tableName,
invalidateKeyQueries,
partitionInvalidateKeyQueries,
type: preAggregation.type,
external: preAggregation.external,
previewSql: queryForSqlEvaluation.preAggregationPreviewSql(tableName),
Expand Down
Loading