-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(tesseract): Rolling window with custom granularities without date range #9762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tesseract): Rolling window with custom granularities without date range #9762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9762 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 231 232 +1
Lines 85650 86447 +797
==========================================
+ Hits 72163 72845 +682
- Misses 13487 13602 +115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return [`'${intervalParsed.hour}:${intervalParsed.minute}:${intervalParsed.second}' HOUR TO SECOND`, 'SECOND']; | ||
| } else if (intervalParsed.minute && intervalParsed.second && intKeys === 2) { | ||
| return [`'${intervalParsed.minute}:${intervalParsed.second}' MINUTE TO SECOND`, 'SECOND']; | ||
| } else if (intervalParsed.millisecond && intKeys === 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we miss other cases like 10 hour / 11 minute / 25 second?....
| templates.types.float = 'REAL'; | ||
| templates.types.double = 'DOUBLE PRECISION'; | ||
| templates.types.binary = 'BYTEA'; | ||
| templates.tesseract.support_generated_series_for_custom_td = 'YES'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a configuration that is put into templates?
KSDaemon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM!
Check List