Skip to content

Conversation

@MazterQyou
Copy link
Member

@MazterQyou MazterQyou commented Jul 9, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR improves compatibility with DBeaver CE. List of issues fixed:

  • Added support for pg_get_keypartdef, pg_relation_size system functions
  • Added support for pg_shdescription system table
  • Fixed placeholder logic to avoid assuming placeholder is a string and infer type from passed oids instead
  • Rewritten system queries that use the same column name more than once or use unsupported join conditions

Related tests are included.

@MazterQyou MazterQyou requested a review from a team as a code owner July 9, 2025 18:45
@MazterQyou MazterQyou force-pushed the cubesql/fix-dbeaver-support branch from 9407730 to 407dfbc Compare July 9, 2025 18:46
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@MazterQyou MazterQyou force-pushed the cubesql/fix-dbeaver-support branch from 407dfbc to c8e7a38 Compare July 9, 2025 19:38
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 87.44395% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (185db54) to head (c8e7a38).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/sql/types.rs 0.00% 18 Missing ⚠️
...ne/information_schema/postgres/pg_shdescription.rs 83.63% 9 Missing ⚠️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9769    +/-   ##
========================================
  Coverage   84.27%   84.28%            
========================================
  Files         232      233     +1     
  Lines       86495    86704   +209     
========================================
+ Hits        72894    73075   +181     
- Misses      13601    13629    +28     
Flag Coverage Δ
cubesql 84.28% <87.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit c206c90 into master Jul 9, 2025
82 checks passed
@MazterQyou MazterQyou deleted the cubesql/fix-dbeaver-support branch July 9, 2025 20:54
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants