fix(tesseract): Fix infine loops during calendar time dimension processing #9772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also restructured tests
skipped for as not supported by tesseract
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9772 +/- ##
=======================================
Coverage 84.27% 84.28%
=======================================
Files 233 233
Lines 86704 86704
=======================================
+ Hits 73067 73075 +8
+ Misses 13637 13629 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waralexrom
approved these changes
Jul 11, 2025
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
…cessing (cube-js#9772) * fix serialization as interval is now optional for granularity * fix the infinite loop eval of calendar time shifts * fix time shifts for cases when they are defined on the pk * add tests for common queries of calendar td Also restructured tests * fix recursion for time shifts plain values * prepare tests for pk time shift skipped for as not supported by tesseract * cargo fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List