Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 15, 2025

  • throw error if named timeshift not found
  • feat(tesseract): Allow named calendar timeshifts for common intervals
  • add tests

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (e033aaf) to head (5ef6e08).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9777   +/-   ##
=======================================
  Coverage   84.27%   84.28%           
=======================================
  Files         233      233           
  Lines       86704    86704           
=======================================
+ Hits        73067    73075    +8     
+ Misses      13637    13629    -8     
Flag Coverage Δ
cubesql 84.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review July 15, 2025 12:20
@KSDaemon KSDaemon requested a review from a team as a code owner July 15, 2025 12:20
@KSDaemon KSDaemon merged commit a5f8a2e into master Jul 16, 2025
82 checks passed
@KSDaemon KSDaemon deleted the fix/tesseract-timeshifts-dims branch July 16, 2025 11:44
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
…cube-js#9777)

* throw error if named timeshift not found

* feat(tesseract): Allow named calendar timeshifts for common intervals

* add tests

* cargo fmt

* update snapshots

* fix

* simplify builder by moving extract_time_shifts to time_shift_state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants