Skip to content

fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client #9790

merged 3 commits into from
Jul 17, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 17, 2025

No description provided.

@KSDaemon KSDaemon marked this pull request as ready for review July 17, 2025 14:26
@KSDaemon KSDaemon requested a review from a team as a code owner July 17, 2025 14:26
@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (f1dff82) to head (4df9a9c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ubeclient/src/models/v1_cube_meta_nested_folder.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #9790       +/-   ##
===========================================
+ Coverage        0   84.32%   +84.32%     
===========================================
  Files           0      234      +234     
  Lines           0    86954    +86954     
===========================================
+ Hits            0    73321    +73321     
- Misses          0    13633    +13633
Flag Coverage Δ
cubesql 84.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ovr
ovr reviewed Jul 17, 2025
View reviewed changes
@KSDaemon KSDaemon merged commit d78cd6b into master Jul 17, 2025
82 checks passed
@KSDaemon KSDaemon deleted the fix/meta-folders-client branch July 17, 2025 20:16
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
@KSDaemon @Frank-TXS
fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client (cu…
9f08adc 
…be-js#9790)

* fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client

* add support for nested folders

* Correct exports
igorlukanin pushed a commit that referenced this pull request Oct 29, 2025
@KSDaemon @igorlukanin
fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client (#9790
cf4f731 
)

* fix(cubesql): Add missing pub CubeMetaNestedFolder in cube client

* add support for nested folders

* Correct exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

@MazterQyou MazterQyou MazterQyou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KSDaemon @ovr @MazterQyou