Skip to content

fix: Send column schema and empty data for empty /cubesql result sets instead of empty response #9798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2025
Merged

fix: Send column schema and empty data for empty /cubesql result sets instead of empty response #9798

merged 3 commits into from
Jul 20, 2025

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jul 19, 2025 •
edited
Loading

…ult sets

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner July 19, 2025 22:17
@paveltiunov paveltiunov changed the title fix: Send column schema and empty data for empty handle_sql_query res… fix: Send column schema and empty data for empty handle_sql_query result sets instead of empty response Jul 19, 2025
@paveltiunov paveltiunov changed the title fix: Send column schema and empty data for empty handle_sql_query result sets instead of empty response fix: Send column schema and empty data for empty /cubesql result sets instead of empty response Jul 19, 2025
@codecov
Copy link

codecov bot commented Jul 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (d78cd6b) to head (95fbd28).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9798   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         234      234           
  Lines       86954    86954           
=======================================
  Hits        73321    73321           
  Misses      13633    13633
Flag Coverage Δ
cubesql 84.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paveltiunov paveltiunov merged commit 113f45b into master Jul 20, 2025
82 checks passed
@paveltiunov paveltiunov deleted the empty-cubesql-result-sets branch July 20, 2025 03:17
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
@paveltiunov @Frank-TXS
fix: Send column schema and empty data for empty /cubesql result sets…
07249a6 
… instead of empty response (cube-js#9798)

* fix: Send column schema and empty data for empty handle_sql_query result sets

* Linter

* Add E2E test
igorlukanin pushed a commit that referenced this pull request Oct 29, 2025
@paveltiunov @igorlukanin
fix: Send column schema and empty data for empty /cubesql result sets…
8cc02be 
… instead of empty response (#9798)

* fix: Send column schema and empty data for empty handle_sql_query result sets

* Linter

* Add E2E test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paveltiunov