Skip to content

fix(schema-compiler): Fix joins getter in cube symbols #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix(schema-compiler): Fix joins getter in cube symbols #9904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions packages/cubejs-schema-compiler/src/compiler/CubeSymbols.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,27 @@ export class CubeSymbols {

get joins() {
if (!joins) {
const parentJoins = cubeDefinition.extends ? super.joins : [];
joins = [...parentJoins, ...(cubeDefinition.joins || [])];
// In dynamic models we still can hit the cases where joins are returned as map
// instead of array, so we need to convert them here to array.
// TODO: Simplify/Remove this when we drop map joins support totally.
let parentJoins = cubeDefinition.extends ? super.joins : [];
if (!Array.isArray(parentJoins)) {
parentJoins = Object.entries(parentJoins).map(([name, join]: [string, any]) => {
join.name = name;
return join as JoinDefinition;
});
}

let localJoins = cubeDefinition.joins || [];
// TODO: Simplify/Remove this when we drop map joins support totally.
if (!Array.isArray(localJoins)) {
localJoins = Object.entries(localJoins).map(([name, join]: [string, any]) => {
join.name = name;
return join as JoinDefinition;
});
}

joins = [...parentJoins, ...localJoins];
}
return joins;
},
Expand Down
Loading