Skip to content

feat(cubesql): Add "planningId" param to SQL API planning events #9939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

feat(cubesql): Add "planningId" param to SQL API planning events #9939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rust/cubesql/cubesql/src/compile/query_engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ use datafusion::{
sql::{parser::Statement as DFStatement, planner::SqlToRel},
variable::VarType,
};
use uuid::Uuid;

#[async_trait::async_trait]
pub trait QueryEngine {
Expand Down Expand Up @@ -100,6 +101,7 @@ pub trait QueryEngine {
let cache_entry = self.get_cache_entry(state.clone()).await?;

let planning_start = SystemTime::now();
let query_planning_id = Uuid::new_v4();
if let Some(span_id) = span_id.as_ref() {
if let Some(auth_context) = state.auth_context() {
self.transport_ref()
Expand All @@ -110,6 +112,7 @@ pub trait QueryEngine {
"SQL API Query Planning".to_string(),
serde_json::json!({
"query": span_id.query_key.clone(),
"planningId": query_planning_id.to_string(),
}),
)
.await
Expand Down Expand Up @@ -183,7 +186,9 @@ pub trait QueryEngine {
auth_context,
state.get_load_request_meta("sql"),
"SQL API Plan Rewrite".to_string(),
serde_json::json!({}),
serde_json::json!({
"planningId": query_planning_id.to_string(),
}),
)
.await
.map_err(|e| CompilationError::internal(e.to_string()))?;
Expand Down Expand Up @@ -292,6 +297,7 @@ pub trait QueryEngine {
state.get_load_request_meta("sql"),
"SQL API Plan Rewrite Success".to_string(),
serde_json::json!({
"planningId": query_planning_id.to_string(),
"duration": rewriting_start.elapsed().unwrap().as_millis() as u64,
}),
)
Expand Down Expand Up @@ -326,6 +332,7 @@ pub trait QueryEngine {
"SQL API Query Planning Success".to_string(),
serde_json::json!({
"query": span_id.query_key.clone(),
"planningId": query_planning_id.to_string(),
"duration": planning_start.elapsed().unwrap().as_millis() as u64,
}),
)
Expand Down
Loading