Support peak_measured_mem on Windows
#623
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
windows-peak-mem
branch
2 times, most recently
from
126137c to
8ea7186
Compare
|
This is failing for Windows on Lithops, since Lithops doesn't support measuring memory on Windows (see https://github.com/lithops-cloud/lithops/blob/fdb6432e9fdc1191a4205579efc0bac32bd8daf7/lithops/worker/utils.py#L151-L152). In addition, it seems to be returning "None" (as a string), which looks like a Lithops bug that should be reported upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
This is needed for #621[No longer true as the threads executor does not need to measure memory since tasks don't run in isolation]