Skip to content

Conversation

@Snuffy2
Copy link
Contributor

@Snuffy2 Snuffy2 commented Nov 23, 2025

This pull request introduces improvements to documentation, type annotations, and error handling, as well as code cleanup for better maintainability and clarity. The most significant changes are grouped below.

Documentation and Installation Improvements:

  • Updated README.md to clarify installation instructions for image generation/editing, now supporting both manual installation and an extras-based install (mlx-openai-server[image-generation]). Added instructions for enhanced caching support via an enhanced-caching extra. [1] [2] [3] [4] [5]

Type Annotations and Code Cleanup:

Error Handling Improvements:

  • Enhanced error logging to include exception types and stack traces, using logger.exception for more informative diagnostics during server startup, handler initialization, and shutdown. [1] [2]

General Codebase Cleanup:

  • Removed unused global variables and legacy comments, and refactored function docstrings for clarity and consistency. [1] [2] [3]

Middleware and Server Setup Enhancements:

  • Improved the HTTP middleware in app/server.py with explicit type annotations and more detailed docstrings for request handling and process time measurement.

@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-main-app-files branch 3 times, most recently from 8b4e6ce to ba34096 Compare December 5, 2025 21:46
@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-main-app-files branch 3 times, most recently from dda2737 to a264a36 Compare December 15, 2025 04:10
@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-main-app-files branch from a264a36 to 8b32373 Compare December 28, 2025 02:48
@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-main-app-files branch from 8b32373 to f161783 Compare January 6, 2026 02:18
@Snuffy2
Copy link
Contributor Author

Snuffy2 commented Jan 6, 2026

@cubist38 any chance of getting these Linting PRs reviewed and merged? I've been rebasing them to keep them ready to merge.

@Snuffy2 Snuffy2 force-pushed the Linting/Formatting-of-main-app-files branch from f161783 to df60227 Compare January 8, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant