pifo-hardware: Initial Pifo Mesh Implementation #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanmohan
requested changes
Nov 6, 2025
Contributor
anshumanmohan
left a comment
anshumanmohan
left a comment
There was a problem hiding this comment.
Super cool! I know no Scala and so I'm not going to actually leave a serious review, but I'll point out two quick things:
- Let's find other variable names than
masterandslave. The community is moving away from those, and I think we can too! - Is there a code formatter for Scala that you'd like to quickly add to our CI? For example, at Capra we require that Python code be formatted with Black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and refactoring to the PIFO hardware codebase to support a runtime configurable Pifo Mesh implementation.