Skip to content

Use Java 17 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+38 −19
Draft

Use Java 17 #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4acf42e
Use Java 17
mpkorstanje Nov 10, 2025
935e2d6
Run checkstyle in validate phase
mpkorstanje Nov 13, 2025
c54e7fe
Cleanup dependencies
mpkorstanje Nov 14, 2025
28af17b
Update versions and polish
mpkorstanje Nov 14, 2025
15b5c2a
WIP
mpkorstanje Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions devkit/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions java/.mvn/jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED
24 changes: 21 additions & 3 deletions java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
<parent>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-parent</artifactId>
<version>4.5.0</version>
<version>5.0.0-SNAPSHOT</version>
</parent>

<artifactId>compatibility-kit</artifactId>
<version>24.0.2-SNAPSHOT</version>
<version>25.0.0-SNAPSHOT</version>
<packaging>jar</packaging>
<name>Compatibility Kit</name>
<description>Test data used to validate a Cucumber implementation</description>
Expand Down Expand Up @@ -51,7 +51,7 @@
<dependency>
<groupId>io.cucumber</groupId>
<artifactId>messages</artifactId>
<version>30.1.0</version>
<version>32.0.0-SNAPSHOT</version>
<scope>provided</scope>
</dependency>

Expand All @@ -67,4 +67,22 @@
<scope>test</scope>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
<execution>
<id>validate</id>
<phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
4 changes: 4 additions & 0 deletions java/src/main/java/io/cucumber/compatibilitykit/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
@NullMarked
package io.cucumber.compatibilitykit;

import org.jspecify.annotations.NullMarked;
4 changes: 2 additions & 2 deletions java/src/test/java/io/cucumber/compatibilitykit/MessageOrdererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ void worksOnEmptyLists(){
@Test
void worksOnListsWithoutTestRunEvents(){
List<Envelope> t = Arrays.asList(
Envelope.of(new TestRunStarted(new Timestamp(0L, 0L), "")),
Envelope.of(new TestRunFinished(null, false, new Timestamp(0L, 0L), null, ""))
Envelope.of(new TestRunStarted(new Timestamp(0L, 0), "")),
Envelope.of(new TestRunFinished(null, false, new Timestamp(0L, 0), null, ""))
);
assertDoesNotThrow(() -> originalOrder.accept(t));
assertDoesNotThrow(() -> simulateParallelExecution.accept(t));
Expand Down