Skip to content

Conversation

@nodeg
Copy link
Member

@nodeg nodeg commented Mar 14, 2025

🤔 What's changed?

As per the deprecation warning and explanation at https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

⚡️ What's your motivation?

See cucumber/common#2150

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Is the changelog entry fine this way?

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@nodeg nodeg self-assigned this Mar 14, 2025
@nodeg nodeg marked this pull request as ready for review March 14, 2025 21:00
@mpkorstanje mpkorstanje self-requested a review March 15, 2025 07:09
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, but see comments.

@nodeg nodeg requested a review from mpkorstanje March 20, 2025 14:24
@nodeg
Copy link
Member Author

nodeg commented Mar 20, 2025

Please squash my commits (one fixup) into one before merging.

@mpkorstanje mpkorstanje merged commit 5e87281 into cucumber:main Mar 20, 2025
29 checks passed
@mpkorstanje
Copy link
Contributor

Cheers!

@nodeg nodeg deleted the ci_set_output branch March 20, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants