Skip to content

Add KeyboardFriendlyDecimalFormatSymbols to public API #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2025
Merged

Add KeyboardFriendlyDecimalFormatSymbols to public API #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d74467
public KeyboardFriendlyDecimalFormatSymbols enables custom reuse
antagoony Nov 23, 2025
bab8f8d
Apply suggestions from code review
antagoony Nov 24, 2025
d439e24
put changelog entry on a single line
antagoony Nov 24, 2025
2ff842f
add "@API(status = API.Status.EXPERIMENTAL)"
antagoony Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- [Ruby] Minor cosmetic / CI changes for development (Nothing front-facing)
- [Python] PEP 639 licence metadata specification ([#361](https://github.com/cucumber/cucumber-expressions/pull/361))
- [Java] Add OSGi metadata
### Added
- [Java] class `KeyboardFriendlyDecimalFormatSymbols` is now `public` and can be used when creating a custom `Locale`-aware type transformation method ([#376](https://github.com/cucumber/cucumber-expressions/issues/376) [antagoony](https://github.com/antagoony))

### Removed
- [Python] Remove support for end-of-life Python 3.8 and 3.9 ([#359](https://github.com/cucumber/cucumber-expressions/pull/359))
Expand Down
7 changes: 5 additions & 2 deletions java/src/main/java/io/cucumber/cucumberexpressions/KeyboardFriendlyDecimalFormatSymbols.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.cucumber.cucumberexpressions;

import org.apiguardian.api.API;

import java.text.DecimalFormatSymbols;
import java.util.Locale;

Expand All @@ -8,9 +10,10 @@
* <p>
* Note quite complete, feel free to make a suggestion.
*/
class KeyboardFriendlyDecimalFormatSymbols {
@API(status = API.Status.EXPERIMENTAL)
public final class KeyboardFriendlyDecimalFormatSymbols {

static DecimalFormatSymbols getInstance(Locale locale) {
public static DecimalFormatSymbols getInstance(Locale locale) {
DecimalFormatSymbols symbols = DecimalFormatSymbols.getInstance(locale);

// Replace the minus sign with minus-hyphen as available on most keyboards.
Expand Down