Locale-aware DefaultParameterTransformer #3114
Open
+107
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
reviewed
Nov 24, 2025
|
|
||
| @Override | ||
| public ParameterByTypeTransformer parameterByTypeTransformer(Locale locale) { | ||
| return (fromValue, toValueType) -> execute(fromValue, toValueType, locale); |
Contributor
There was a problem hiding this comment.
This puts state in an otherwise stateless component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Following your response this MR optionally injects the locale information of the current Feature/Pickle into the custom
@DefaultParameterTransformermethod.This is done by adding support for two more method signatures as proposed by this response of cucumber/cucucmber-expressions#376.
⚡️ What's your motivation?
See issue "Getting knowledge about the current Locale within any custom @DefaultParameterTransformer" (cucumber/cucumber-expressions#376).
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I am not sure if adding a note within the CHANGELOG is sufficient enough.
📋 Checklist: