Handle messages with fields omitted #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Use
parseEnvelope
from the messages library that deserialises all envelopes into classes that have default values for numbers (0
), arrays ([]
) and strings (""
), rather than a plainJSON.parse
.⚡️ What's your motivation?
We can see from telemetry that some client-side errors are happening when reports are rendered for things like:
Timestamp
with undefnednanos
Scenario
with undefinedexamples
Whilst I think it's a bad thing in the long term (and have been trying to get rid of it, prematurely in retrospect), we need to have it for now so we tolerate missing fields, and then ideally establish the gaps with schema adherence and close them over time.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.