feature: Implement Cucumber::Query in-line with Java/JS implementations #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lope testing working for the formatter
…grated with our repository and (in 2 instances, fully), functional
…mpty) that validate find all pickles returns the correct number. Next step is to extend this to test 3/4/5 files for JUST find all pickles
…for pickle and test case
…the 5 CCK items we test against currently
luke-hill
changed the title
mpkorstanje
reviewed
Nov 25, 2025
lib/cucumber/repository.rb
Outdated
| def update_test_step_finished(test_step_finished) | ||
| # Java impl: | ||
| # this.testStepsFinishedByTestCaseStartedId.compute(event.getTestCaseStartedId(), updateList(event)); | ||
| test_steps_finished_by_test_case_started_id[test_step_finished.test_case_started_id] = test_step_finished |
Contributor
There was a problem hiding this comment.
The relationship here is a one to many relationship test_case_started_id (1) --> (*) test_step_finished.
So the data structure should look like
{
"Id1" => [ object1, object2, ... ],
"id2" => [ object10, object11, ... ],
}
…key by default as an array - allowing enumeration
…t into a single construct
NB: the find_all query needs a little fix
…ir of update calls Add update_scenario which is a simple wrapper around updating steps
…e and findAllStepDefinitions query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial pass at implementing the "correct" style of cucumber query inline with Java/JS implementations
Type of change
Please delete options that are not relevant.
work as expected)
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses