fix: avoid panic when post hook panic #699
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
add defer/recover logic in
runAfterStepHooks
andrunAfterScenarioHooks
, so the panic happens in post hook would be handled gracefully( just like the pre hook)⚡️ What's your motivation?
Fix #662 .
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
While I haven't updated the post-hook to output the infomation of panics in the same format as the pre-hook, this change already ensures that the program doesn't stop entirely if a panic occurs in a post-hook. Is that fine?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.