Skip to content

dotnet: allow customizing resources in subclasses #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Added
- [.Net] Added possiblity to customize resources in subclasses of MessagesToHtmlWriter ([#400](https://github.com/cucumber/html-formatter/pull/400))

## [21.13.0] - 2025-07-07
### Changed
Expand Down
49 changes: 32 additions & 17 deletions dotnet/Cucumber.HtmlFormatter/MessagesToHtmlWriter.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Io.Cucumber.Messages.Types;
using System.Reflection;
using Io.Cucumber.Messages.Types;

namespace Cucumber.HtmlFormatter;

Expand All @@ -7,14 +8,16 @@ public class MessagesToHtmlWriter : IDisposable
private readonly StreamWriter _writer;
private readonly Func<StreamWriter, Envelope, Task> _asyncStreamSerializer;
private readonly Action<StreamWriter, Envelope> _streamSerializer;
private readonly string _template;
private readonly Lazy<string> _template;
private readonly JsonInHtmlWriter _jsonInHtmlWriter;
private bool _streamClosed = false;
private bool _preMessageWritten = false;
private bool _firstMessageWritten = false;
private bool _postMessageWritten = false;
private readonly bool _isAsyncInitialized = false;

private string Template => _template.Value;

[Obsolete("Cucumber.HtmlFormatter moving to async only operations. Please use the MessagesToHtmlWriter(Stream, Func<StreamWriter, Envelope, Task>) constructor", false)]
public MessagesToHtmlWriter(Stream stream, Action<StreamWriter, Envelope> streamSerializer) : this(new StreamWriter(stream), streamSerializer)
{
Expand All @@ -24,15 +27,15 @@ public MessagesToHtmlWriter(Stream stream, Func<StreamWriter, Envelope, Task> as
[Obsolete("Cucumber.HtmlFormatter moving to async only operations. Please use the MessagesToHtmlWriter(StreamWriter, Func<StreamWriter, Envelope, Task>) constructor", false)]
public MessagesToHtmlWriter(StreamWriter writer, Action<StreamWriter, Envelope> streamSerializer)
{
this._writer = writer;
this._streamSerializer = streamSerializer;
_writer = writer;
_streamSerializer = streamSerializer;
// Create async wrapper for sync serializer
this._asyncStreamSerializer = (w, e) =>
_asyncStreamSerializer = (w, e) =>
{
streamSerializer(w, e);
return Task.CompletedTask;
};
_template = GetResource("index.mustache.html");
_template = new Lazy<string>(() => GetResource("index.mustache.html"));
_jsonInHtmlWriter = new JsonInHtmlWriter(writer);
_isAsyncInitialized = false;
}
Expand All @@ -42,37 +45,37 @@ public MessagesToHtmlWriter(StreamWriter writer, Func<StreamWriter, Envelope, Ta
this._asyncStreamSerializer = asyncStreamSerializer;
// Create sync wrapper for async serializer (will block)
this._streamSerializer = (w, e) => asyncStreamSerializer(w, e).GetAwaiter().GetResult();
_template = GetResource("index.mustache.html");
_template = new Lazy<string>(() => GetResource("index.mustache.html"));
_jsonInHtmlWriter = new JsonInHtmlWriter(writer);
_isAsyncInitialized = true;
}

private void WritePreMessage()
{
WriteTemplateBetween(_writer, _template, null, "{{css}}");
WriteTemplateBetween(_writer, Template, null, "{{css}}");
WriteResource(_writer, "main.css");
WriteTemplateBetween(_writer, _template, "{{css}}", "{{messages}}");
WriteTemplateBetween(_writer, Template, "{{css}}", "{{messages}}");
}

private async Task WritePreMessageAsync()
{
await WriteTemplateBetweenAsync(_writer, _template, null, "{{css}}");
await WriteTemplateBetweenAsync(_writer, Template, null, "{{css}}");
await WriteResourceAsync(_writer, "main.css");
await WriteTemplateBetweenAsync(_writer, _template, "{{css}}", "{{messages}}");
await WriteTemplateBetweenAsync(_writer, Template, "{{css}}", "{{messages}}");
}

private void WritePostMessage()
{
WriteTemplateBetween(_writer, _template, "{{messages}}", "{{script}}");
WriteTemplateBetween(_writer, Template, "{{messages}}", "{{script}}");
WriteResource(_writer, "main.js");
WriteTemplateBetween(_writer, _template, "{{script}}", null);
WriteTemplateBetween(_writer, Template, "{{script}}", null);
}

private async Task WritePostMessageAsync()
{
await WriteTemplateBetweenAsync(_writer, _template, "{{messages}}", "{{script}}");
await WriteTemplateBetweenAsync(_writer, Template, "{{messages}}", "{{script}}");
await WriteResourceAsync(_writer, "main.js");
await WriteTemplateBetweenAsync(_writer, _template, "{{script}}", null);
await WriteTemplateBetweenAsync(_writer, Template, "{{script}}", null);
}

public void Write(Envelope envelope)
Expand Down Expand Up @@ -217,9 +220,21 @@ private async Task WriteTemplateBetweenAsync(StreamWriter writer, string templat
await writer.WriteAsync(template.Substring(beginIndex, lengthToWrite));
}

private string GetResource(string name)
/// <summary>
/// Returns the assembly where the resources are located. The default implementation returns the package assembly ('Cucumber.HtmlFormatter').
/// </summary>
protected virtual Assembly GetResourceAssembly()
{
return typeof(MessagesToHtmlWriter).Assembly;
}

/// <summary>
/// Returns a resource for the generated HTML page.
/// </summary>
/// <param name="name">The resource file name. Either 'index.mustache.html', 'main.css' or 'main.js'.</param>
protected virtual string GetResource(string name)
{
var assembly = typeof(MessagesToHtmlWriter).Assembly;
var assembly = GetResourceAssembly();
var resourceStream = assembly.GetManifestResourceStream("Cucumber.HtmlFormatter.Resources." + name);
if (resourceStream == null)
throw new InvalidOperationException($"Resource '{name}' not found in assembly '{assembly.FullName}'");
Expand Down