Skip to content

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 14, 2024

🤔 What's changed?

A few stray fixes for things I didn't catch in #62

  • countTestCasesStarted now accounts for retries (by way of calling findAllTestCaseStarted internally)
  • findPickleStepBy now calls requireNonNull on the right argument
  • Update the support matrix in the README
  • Export Lineage and related symbols in JS on entry point

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review November 14, 2024 21:12
@davidjgoss davidjgoss changed the title Stray fixes in Java implementation Stray fixes in Java and JS Nov 14, 2024
@davidjgoss davidjgoss merged commit 6615cb1 into main Nov 14, 2024
8 checks passed
@davidjgoss davidjgoss deleted the fix/stray-fixes branch November 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant