Skip to content

[ACHYDRA-1029] Update omniauth-cul to 0.3.0#345

Open
goldsmithb wants to merge 1 commit intomainfrom
1029
Open

[ACHYDRA-1029] Update omniauth-cul to 0.3.0#345
goldsmithb wants to merge 1 commit intomainfrom
1029

Conversation

@goldsmithb
Copy link
Contributor

Jira Ticket


This PR upgrades our omniauth-cul gem version to 0.3.0, which comes with some breaking changes and includes a developer strategy of its own.

This PR:

  • replaces the custom code we had to use the devise developer strategy with the omniauth-cul provided developer_uid strategy (less finagling of devise routes on our part -- much simpler setup)
  • replaces the :cas strategy with the :columbia_cas strategy (new implementation from omniauth-cul)
  • adds a flash success message after signing in
  • removes omniauth-rails_csrf_protection gem (not needed in omniauth v2+)

Copy link
Contributor

@JackBlackLight JackBlackLight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @goldsmithb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants