Skip to content

tests: DOMPurify custom window test improvement #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cure53 merged 1 commit into from
Jan 22, 2025
Merged

tests: DOMPurify custom window test improvement #1060

cure53 merged 1 commit into from
Jan 22, 2025

Conversation

@yehuya
Copy link

@yehuya yehuya commented Jan 22, 2025

Summary

  1. Improved the "DOMPurify custom window" test to ensure that the document and window.Element are tested separately.
  2. Increased the likelihood of the test failing if a new window property is required in the future, thereby reducing the risk of future TypeError: Cannot read properties of undefined errors.

@cure53
Copy link
Owner

cure53 commented Jan 22, 2025

Thank you, this LGTM

@cure53 cure53 merged commit 0d64d2b into cure53:main Jan 22, 2025
8 checks passed
@yehuya yehuya deleted the initializeTestImprovements branch January 22, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yehuya @cure53