chore(package.json): add dist/purify.js and dist/purify.min.js to exports as targetable modules#1065
Merged
cure53 merged 1 commit intocure53:mainfrom Feb 22, 2025
Merged
chore(package.json): add dist/purify.js and dist/purify.min.js to exports as targetable modules#1065cure53 merged 1 commit intocure53:mainfrom
dist/purify.js and dist/purify.min.js to exports as targetable modules#1065cure53 merged 1 commit intocure53:mainfrom
Conversation
… exports as targetable modules
Owner
|
Hey there, thanks a lot, this looks great 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request tries to solve a similar issue as described in: #1050 and fixed in #1053
In our case we are importing this lib via
dompurify/dist/purify.js. Which fails with the recent versions of this lib since theexportsfield was introduced with this error message:Background & Context
I won't go to much into details here as it is basically the same story as in #1053.
This could probably also be solved by anyone using this lib by adapting the import of this lib from
dompurify/dist/purify.jstodompurify/purify.js, but this way it would not require a change for anyone still usingdompurify/dist/purify.js.Tasks
Dependencies