Fix deeply nested local function compilation and sibling order\n\n- M…#134
Open
theolivenbaum wants to merge 2 commits intomasterfrom
Open
Fix deeply nested local function compilation and sibling order\n\n- M…#134theolivenbaum wants to merge 2 commits intomasterfrom
theolivenbaum wants to merge 2 commits intomasterfrom
Conversation
…odified `LocalFunctionReplacer` to sort local functions by nesting depth (descending) and then by document position (ascending). This ensures inner functions are processed before outer functions (correctly handling nesting) while processing sibling functions in their original order.\n- Introduced `tempInits` to buffer initialization statements within the processing loop, ensuring declarations are always added in document order regardless of processing order.\n- Fixed a potential `KeyNotFoundException` in `updatedBlocks` merging by checking `tempInits` inside the loop for nested block updates and handling the consumption of initialization statements incrementally.\n- Verified fix with `MinimumFailing_DeeplyNestedLocals` integration test. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
…odified `LocalFunctionReplacer` to sort local functions by nesting depth (descending) and then by document position (ascending). This ensures inner functions are processed before outer functions (correctly handling nesting) while processing sibling functions in their original order.\n- Introduced `tempInits` to buffer initialization statements within the processing loop, ensuring declarations are always added in document order regardless of processing order.\n- Fixed a potential `KeyNotFoundException` in `updatedBlocks` merging by checking `tempInits` inside the loop for nested block updates and handling the consumption of initialization statements incrementally.\n- Verified fix with `MinimumFailing_DeeplyNestedLocals` integration test. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…odified
LocalFunctionReplacerto sort local functions by nesting depth (descending) and then by document position (ascending). This ensures inner functions are processed before outer functions (correctly handling nesting) while processing sibling functions in their original order.\n- IntroducedtempInitsto buffer initialization statements within the processing loop, ensuring declarations are always added in document order regardless of processing order.\n- Fixed a potentialKeyNotFoundExceptioninupdatedBlocksmerging by checkingtempInitsinside the loop for nested block updates and handling the consumption of initialization statements incrementally.\n- Verified fix withMinimumFailing_DeeplyNestedLocalsintegration test.