Fix argument emission for extension methods on InvocationExpression t…#260
Open
theolivenbaum wants to merge 1 commit intomasterfrom
Open
Fix argument emission for extension methods on InvocationExpression t…#260theolivenbaum wants to merge 1 commit intomasterfrom
theolivenbaum wants to merge 1 commit intomasterfrom
Conversation
…arget Modified `InvocationBlock.WriteThisExtension` to explicitly handle `MemberReferenceExpression` targets by visiting the `Target` property. This prevents incorrect emission (stripping of arguments) when the receiver of an extension method call is itself an `InvocationExpression` (e.g., `Method().Extension()`), which previously relied on brittle `Children.ElementAt(0)` logic. Added regression test `Tests/H5.Compiler.IntegrationTests/Language/ExtensionMethodInvocationTest.cs`. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…arget
Modified
InvocationBlock.WriteThisExtensionto explicitly handleMemberReferenceExpressiontargets by visiting theTargetproperty. This prevents incorrect emission (stripping of arguments) when the receiver of an extension method call is itself anInvocationExpression(e.g.,Method().Extension()), which previously relied on brittleChildren.ElementAt(0)logic.Added regression test
Tests/H5.Compiler.IntegrationTests/Language/ExtensionMethodInvocationTest.cs.